FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is

Effort is max

Summary

Classes Bugs Errors Missing Classes
492 29 0 0

org.apache.hadoop.chukwa.ChukwaArchiveKey$Comparator

Bug Category Details Line Priority
Dead store to l1 in org.apache.hadoop.chukwa.ChukwaArchiveKey$Comparator.compareRaw(byte[], int, int, byte[], int, int) STYLE DLS_DEAD_LOCAL_STORE 359 Medium
Dead store to l2 in org.apache.hadoop.chukwa.ChukwaArchiveKey$Comparator.compareRaw(byte[], int, int, byte[], int, int) STYLE DLS_DEAD_LOCAL_STORE 360 Medium
Dead store to s2 in org.apache.hadoop.chukwa.ChukwaArchiveKey$Comparator.compareRaw(byte[], int, int, byte[], int, int) STYLE DLS_DEAD_LOCAL_STORE 358 Medium
Dead store to l in org.apache.hadoop.chukwa.ChukwaArchiveKey$Comparator.slurpRaw(byte[], int, int) STYLE DLS_DEAD_LOCAL_STORE 286 Medium
org.apache.hadoop.chukwa.ChukwaArchiveKey$Comparator implements Comparator but not Serializable BAD_PRACTICE SE_COMPARATOR_SHOULD_BE_SERIALIZABLE 258-370 Medium

org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder

Bug Category Details Line Priority
Dead store to res in org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder.main(String[]) STYLE DLS_DEAD_LOCAL_STORE 451 Medium

org.apache.hadoop.chukwa.datacollection.collector.servlet.LogDisplayServlet

Bug Category Details Line Priority
The field org.apache.hadoop.chukwa.datacollection.collector.servlet.LogDisplayServlet.chunksBySID is transient but isn't set by deserialization BAD_PRACTICE SE_TRANSIENT_FIELD_NOT_RESTORED Not available Medium

org.apache.hadoop.chukwa.datacollection.writer.gora.ChukwaChunk

Bug Category Details Line Priority
org.apache.hadoop.chukwa.datacollection.writer.gora.ChukwaChunk._ALL_FIELDS should be package protected MALICIOUS_CODE MS_PKGPROTECT 97 Medium

org.apache.hadoop.chukwa.datacollection.writer.gora.GoraWriter

Bug Category Details Line Priority
Can't close GoraWriter.chunkStore since it is always null in org.apache.hadoop.chukwa.datacollection.writer.gora.GoraWriter.close() CORRECTNESS NP_CLOSING_NULL 95 High

org.apache.hadoop.chukwa.datacollection.writer.hbase.HBaseWriter

Bug Category Details Line Priority
Incorrect lazy initialization of static field org.apache.hadoop.chukwa.datacollection.writer.hbase.HBaseWriter.connection in org.apache.hadoop.chukwa.datacollection.writer.hbase.HBaseWriter.init(Configuration) MT_CORRECTNESS LI_LAZY_INIT_STATIC 123-125 Medium
Write to static field org.apache.hadoop.chukwa.datacollection.writer.hbase.HBaseWriter.connection from instance method org.apache.hadoop.chukwa.datacollection.writer.hbase.HBaseWriter.init(Configuration) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 125 Medium

org.apache.hadoop.chukwa.datacollection.writer.solr.SolrWriter

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in org.apache.hadoop.chukwa.datacollection.writer.solr.SolrWriter.add(List) STYLE REC_CATCH_EXCEPTION 119 Medium

org.apache.hadoop.chukwa.datastore.ChukwaHBaseStore

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.hadoop.chukwa.datastore.ChukwaHBaseStore.getData(ArrayList, long, long): new String(byte[]) I18N DM_DEFAULT_ENCODING 729 High

org.apache.hadoop.chukwa.extraction.archive.ChukwaArchiveBuilder

Bug Category Details Line Priority
Dead store to res in org.apache.hadoop.chukwa.extraction.archive.ChukwaArchiveBuilder.main(String[]) STYLE DLS_DEAD_LOCAL_STORE 143 Medium

org.apache.hadoop.chukwa.extraction.demux.Demux

Bug Category Details Line Priority
Dead store to res in org.apache.hadoop.chukwa.extraction.demux.Demux.main(String[]) STYLE DLS_DEAD_LOCAL_STORE 263 Medium
org.apache.hadoop.chukwa.extraction.demux.Demux.jobConf isn't final and can't be protected from malicious code MALICIOUS_CODE MS_CANNOT_BE_FINAL 64 Medium

org.apache.hadoop.chukwa.extraction.engine.ChukwaRecordJT

Bug Category Details Line Priority
Class org.apache.hadoop.chukwa.extraction.engine.ChukwaRecordJT defines non-transient non-serializable instance field mapFields BAD_PRACTICE SE_BAD_FIELD Not available High

org.apache.hadoop.chukwa.extraction.engine.ChukwaRecordJT$Comparator

Bug Category Details Line Priority
org.apache.hadoop.chukwa.extraction.engine.ChukwaRecordJT$Comparator is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 267-376 High

org.apache.hadoop.chukwa.extraction.engine.ChukwaRecordKey$Comparator

Bug Category Details Line Priority
Dead store to l2 in org.apache.hadoop.chukwa.extraction.engine.ChukwaRecordKey$Comparator.compareRaw(byte[], int, int, byte[], int, int) STYLE DLS_DEAD_LOCAL_STORE 260 High
Dead store to l in org.apache.hadoop.chukwa.extraction.engine.ChukwaRecordKey$Comparator.slurpRaw(byte[], int, int) STYLE DLS_DEAD_LOCAL_STORE 221 High
Dead store to l1 in org.apache.hadoop.chukwa.extraction.engine.ChukwaRecordKey$Comparator.compareRaw(byte[], int, int, byte[], int, int) STYLE DLS_DEAD_LOCAL_STORE 269 Medium
Dead store to s2 in org.apache.hadoop.chukwa.extraction.engine.ChukwaRecordKey$Comparator.compareRaw(byte[], int, int, byte[], int, int) STYLE DLS_DEAD_LOCAL_STORE 267 Medium
org.apache.hadoop.chukwa.extraction.engine.ChukwaRecordKey$Comparator implements Comparator but not Serializable BAD_PRACTICE SE_COMPARATOR_SHOULD_BE_SERIALIZABLE 205-279 Medium

org.apache.hadoop.chukwa.hicc.rest.Examples

Bug Category Details Line Priority
org.apache.hadoop.chukwa.hicc.rest.Examples.SYSTEM_LOAD_AVERAGE_WIDGET isn't final but should be refactored to be so MALICIOUS_CODE MS_SHOULD_BE_REFACTORED_TO_BE_FINAL 179 High
org.apache.hadoop.chukwa.hicc.rest.Examples.TOP_APP_WIDGET isn't final but should be refactored to be so MALICIOUS_CODE MS_SHOULD_BE_REFACTORED_TO_BE_FINAL 265 High
Unused public or protected field: org.apache.hadoop.chukwa.hicc.rest.Examples.CPU_METRICS STYLE UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD Not available Medium

org.apache.hadoop.chukwa.hicc.rest.PieChartController

Bug Category Details Line Priority
Unread field: org.apache.hadoop.chukwa.hicc.rest.PieChartController.sdf PERFORMANCE URF_UNREAD_FIELD 52 Medium

org.apache.hadoop.chukwa.hicc.rest.TileController

Bug Category Details Line Priority
Unread field: org.apache.hadoop.chukwa.hicc.rest.TileController.sdf PERFORMANCE URF_UNREAD_FIELD 51 Medium

org.apache.hadoop.chukwa.util.ConstRateValidator

Bug Category Details Line Priority
Dead store to res in org.apache.hadoop.chukwa.util.ConstRateValidator.main(String[]) STYLE DLS_DEAD_LOCAL_STORE 278 Medium